Documents: Add support for URL-specific document variations - refs #5956 #5976
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,71 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; | ||
| use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||
|
|
||
| class AddVariantResourceFileAction |
|
|
||
| class AddVariantResourceFileAction | ||
| { | ||
| public function __invoke(Request $request, EntityManagerInterface $em): ResourceFile |
| @@ -59,6 +63,7 @@ class ResourceController extends AbstractResourceController implements CourseCon | |||
| public function __construct( | |||
| private readonly UserHelper $userHelper, | |||
| private readonly ResourceNodeRepository $resourceNodeRepository, | |||
| private readonly ResourceFileRepository $resourceFileRepository | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
| @@ -136,21 +141,55 @@ | |||
| * View file of a resource node. | |||
| */ | |||
| #[Route('/{tool}/{type}/{id}/view', name: 'chamilo_core_resource_view', methods: ['GET'])] | |||
| public function view(Request $request, TrackEDownloadsRepository $trackEDownloadsRepository): Response | |||
| { | |||
| public function view( | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -212,8 +251,12 @@ public function link(Request $request, RouterInterface $router, CLinkRepository | |||
| * Download file of a resource node. | |||
| */ | |||
| #[Route('/{tool}/{type}/{id}/download', name: 'chamilo_core_resource_download', methods: ['GET'])] | |||
| public function download(Request $request, TrackEDownloadsRepository $trackEDownloadsRepository): Response | |||
| { | |||
| public function download( | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -458,15 +520,46 @@ | |||
| return new Response(null, Response::HTTP_NO_CONTENT); | |||
| } | |||
|
|
|||
| private function processFile(Request $request, ResourceNode $resourceNode, string $mode = 'show', string $filter = '', ?array $allUserInfo = null): mixed | |||
| #[Route('/resource_files/{resourceNodeId}/variants', name: 'chamilo_core_resource_files_variants', methods: ['GET'])] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| @@ -458,15 +520,46 @@ | |||
| return new Response(null, Response::HTTP_NO_CONTENT); | |||
| } | |||
|
|
|||
| private function processFile(Request $request, ResourceNode $resourceNode, string $mode = 'show', string $filter = '', ?array $allUserInfo = null): mixed | |||
| #[Route('/resource_files/{resourceNodeId}/variants', name: 'chamilo_core_resource_files_variants', methods: ['GET'])] | |||
| public function getVariants(string $resourceNodeId, EntityManagerInterface $em): JsonResponse | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -150,6 +183,11 @@ class ResourceFile implements Stringable | |||
| #[ORM\Column(type: 'datetime')] | |||
| protected $updatedAt; | |||
|
|
|||
| #[ORM\ManyToOne(targetEntity: AccessUrl::class)] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| @@ -150,6 +183,11 @@ | |||
| #[ORM\Column(type: 'datetime')] | |||
| protected $updatedAt; | |||
|
|
|||
| #[ORM\ManyToOne(targetEntity: AccessUrl::class)] | |||
| #[ORM\JoinColumn(name: 'access_url_id', referencedColumnName: 'id', nullable: true, onDelete: 'SET NULL')] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| return $this->json($data); | ||
| } | ||
|
|
||
| #[Route('/resource_files/{id}/delete_variant', methods: ['DELETE'], name: 'chamilo_core_resource_files_delete_variant')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| } | ||
|
|
||
| #[Route('/resource_files/{id}/delete_variant', methods: ['DELETE'], name: 'chamilo_core_resource_files_delete_variant')] | ||
| public function deleteVariant(int $id, EntityManagerInterface $em): JsonResponse |
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| @@ -150,6 +183,11 @@ class ResourceFile implements Stringable | |||
| #[ORM\Column(type: 'datetime')] | |||
| protected $updatedAt; | |||
|
|
|||
| #[ORM\ManyToOne(targetEntity: AccessUrl::class)] | |||
| #[ORM\JoinColumn(name: 'access_url_id', referencedColumnName: 'id', nullable: true, onDelete: 'SET NULL')] | |||
| protected ?AccessUrl $accessUrl = null; | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| @@ -332,6 +370,17 @@ | |||
| return $this; | |||
| } | |||
|
|
|||
| public function getAccessUrl(): ?AccessUrl | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| @@ -332,6 +370,17 @@ | |||
| return $this; | |||
| } | |||
|
|
|||
| public function getAccessUrl(): ?AccessUrl | |||
|
Code Climate has analyzed commit 2fc1932 and detected 39 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.